linkbutton: Fix memory leak

strings returned by gtk_widget_get_tooltip_text() and
gtk_widget_get_tooltip_markup() has to be freed when no longer
required.

https://bugzilla.gnome.org/show_bug.cgi?id=782202

diff --git a/gtk/gtklinkbutton.c b/gtk/gtklinkbutton.c
index 1a7a0d6186914db4231141b177f496ed28f316f2..0ce64a2cbbf96f7181b61c2fe73c9cb4f6070e1c 100644 (file)
--- a/gtk/gtklinkbutton.c
+++ b/gtk/gtklinkbutton.c
@@ -582,18 +582,24 @@ gtk_link_button_query_tooltip_cb (GtkWidget    *widget,
 {
   GtkLinkButton *link_button = GTK_LINK_BUTTON (widget);
   const gchar *label, *uri;
+  gchar *text, *markup;
 
   label = gtk_button_get_label (GTK_BUTTON (link_button));
   uri = link_button->priv->uri;
+  text = gtk_widget_get_tooltip_text (widget);
+  markup = gtk_widget_get_tooltip_markup (widget);
 
-  if (!gtk_widget_get_tooltip_text (widget)
-    && !gtk_widget_get_tooltip_markup (widget)
-    && label && *label != '\0' && uri && strcmp (label, uri) != 0)
+  if (text == NULL &&
+      markup == NULL &&
+      label && *label != '\0' && uri && strcmp (label, uri) != 0)
     {
       gtk_tooltip_set_text (tooltip, uri);
       return TRUE;
     }
 
+  g_free (text);
+  g_free (markup);
+
   return FALSE;
 }